Issue 12983010: Manually compute inverted matrix for screen rotation

Issue 12983010: Manually compute inverted matrix for screen rotation (Closed)

Created:
7 years, 9 months ago by oshima

Modified:
7 years, 9 months ago

Reviewers:
Ian Vollick, sky

CC:
chromium-reviews, cc-bugs_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Manually compute inverted matrix for screen rotation BUG=222483 TEST=no functionality change. covered by existing unit tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190533

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -21 lines)			Patch
M	ash/display/display_controller.cc	View	1	2 chunks	+15 lines, -1 line	0 comments	Download
M	ui/aura/root_window.h	View		5 chunks	+14 lines, -1 line	0 comments	Download
M	ui/aura/root_window.cc	View		7 chunks	+34 lines, -12 lines	0 comments	Download
M	ui/base/events/event.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	ui/base/events/event.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/12983010/diff/2002/ash/display/display_controller.cc File ash/display/display_controller.cc (right): https://codereview.chromium.org/12983010/diff/2002/ash/display/display_controller.cc#newcode137 ash/display/display_controller.cc:137: // TODO(oshima): Manually complute the invert of the ...

7 years, 9 months ago (2013-03-25 16:04:32 UTC) #2

oshima

https://codereview.chromium.org/12983010/diff/2002/ash/display/display_controller.cc File ash/display/display_controller.cc (right): https://codereview.chromium.org/12983010/diff/2002/ash/display/display_controller.cc#newcode137 ash/display/display_controller.cc:137: // TODO(oshima): Manually complute the invert of the On ...

7 years, 9 months ago (2013-03-25 17:49:31 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/12983010/13001

7 years, 9 months ago (2013-03-25 17:51:19 UTC) #4

oshima

7 years, 9 months ago (2013-03-26 00:54:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r190533 (presubmit successful).

Expand Messages | Collapse Messages