Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1828)

Issue 1298283003: Fix FEImage SKP bounds (Closed)

Created:
5 years, 4 months ago by f(malita)
Modified:
5 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix FEImage SKP bounds When recording its filterPicture, FEImage::createImageFilterForLayoutObject() transforms the content such that it draws into dstRect - but it keeps the recording bounds at origin (FloatRect(FloatPoint(), dstRect.size())). This means that the picture content can draw outside its declared bounds, and is susceptible to incorrect culling. Since we're mapping the content into dstRect, we should use the same for picture culling. R=senorblanco@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
f(malita)
This is not an issue currently, because picture bounds are only used for BBH culling ...
5 years, 4 months ago (2015-08-20 15:55:24 UTC) #1
Stephen White
LGTM
5 years, 4 months ago (2015-08-20 16:00:42 UTC) #2
Stephen White
BTW, not sure if it's relevant, but see https://chromium.googlesource.com/skia/+/915881fe743f9a789037695f543bc6ea189cd0cb (which just landed).
5 years, 4 months ago (2015-08-20 16:02:53 UTC) #3
f(malita)
On 2015/08/20 16:02:53, Stephen White wrote: > BTW, not sure if it's relevant, but see ...
5 years, 4 months ago (2015-08-20 16:08:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298283003/1
5 years, 4 months ago (2015-08-20 16:08:54 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 17:48:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200914

Powered by Google App Engine
This is Rietveld 408576698