DevTools: [timeline tree view] render visual of percent in the background.

DevTools: [timeline tree view] render visual of percent in the background.

BUG=521225
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200762

[alph, 2015-08-18 21:00:26]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, paulirish@chromium.org

[caseq, 2015-08-18 21:06:29]

https://codereview.chromium.org/1298283002/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineTreeView.js (right):

https://codereview.chromium.org/1298283002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:324: this._maxTime = {
self: maxSelfTime, total: maxTotalTime };
maxTimes?

https://codereview.chromium.org/1298283002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:398:
cell.createChild("div", "background-bar").style.width =
this._profileNode[columnIdentifier + "Time"] * 100 /
this._maxTime[columnIdentifier] + "%";
explicitly format as decimal to prevent accidentally having exponential notation
getting through to CSS?

[caseq, 2015-08-18 21:06:33]

lgtm

[alph, 2015-08-18 21:16:19]

https://codereview.chromium.org/1298283002/diff/1/Source/devtools/front_end/t...
File Source/devtools/front_end/timeline/TimelineTreeView.js (right):

https://codereview.chromium.org/1298283002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:324: this._maxTime = {
self: maxSelfTime, total: maxTotalTime };
On 2015/08/18 21:06:29, caseq wrote:
> maxTimes?

Done.

https://codereview.chromium.org/1298283002/diff/1/Source/devtools/front_end/t...
Source/devtools/front_end/timeline/TimelineTreeView.js:398:
cell.createChild("div", "background-bar").style.width =
this._profileNode[columnIdentifier + "Time"] * 100 /
this._maxTime[columnIdentifier] + "%";
On 2015/08/18 21:06:29, caseq wrote:
> explicitly format as decimal to prevent accidentally having exponential
notation
> getting through to CSS?

Done.

[alph, 2015-08-18 21:27:21]

The CQ bit was checked by alph@chromium.org

[alph, 2015-08-18 21:27:21]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/1298283002/#ps20001
(title: "addressing comments")

[commit-bot: I haz the power, 2015-08-18 21:27:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298283002/20001

[paulirish, 2015-08-18 22:05:39]

lgtm

[commit-bot: I haz the power, 2015-08-18 22:55:35]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200762