Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: net/spdy/spdy_test_util_common.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_stream_unittest.cc ('k') | net/spdy/spdy_test_util_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_test_util_common.h
diff --git a/net/spdy/spdy_test_util_common.h b/net/spdy/spdy_test_util_common.h
index 68bdfdf329666df99c4824f895991fbfd52f81df..7a3d272cb9ce9146e6c1403ed6d8495ef2301508 100644
--- a/net/spdy/spdy_test_util_common.h
+++ b/net/spdy/spdy_test_util_common.h
@@ -194,9 +194,9 @@ struct SpdySessionDependencies {
~SpdySessionDependencies();
- static HttpNetworkSession* SpdyCreateSession(
+ static scoped_ptr<HttpNetworkSession> SpdyCreateSession(
SpdySessionDependencies* session_deps);
- static HttpNetworkSession* SpdyCreateSessionDeterministic(
+ static scoped_ptr<HttpNetworkSession> SpdyCreateSessionDeterministic(
SpdySessionDependencies* session_deps);
static HttpNetworkSession::Params CreateSessionParams(
SpdySessionDependencies* session_deps);
@@ -244,7 +244,7 @@ bool HasSpdySession(SpdySessionPool* pool, const SpdySessionKey& key);
// session pool in |http_session|. A SPDY session for |key| must not
// already exist.
base::WeakPtr<SpdySession> CreateInsecureSpdySession(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
const BoundNetLog& net_log);
@@ -253,14 +253,14 @@ base::WeakPtr<SpdySession> CreateInsecureSpdySession(
// not already exist. The session will be created but close in the
// next event loop iteration.
base::WeakPtr<SpdySession> TryCreateInsecureSpdySessionExpectingFailure(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
Error expected_error,
const BoundNetLog& net_log);
// Like CreateInsecureSpdySession(), but uses TLS.
base::WeakPtr<SpdySession> CreateSecureSpdySession(
- const scoped_refptr<HttpNetworkSession>& http_session,
+ HttpNetworkSession* http_session,
const SpdySessionKey& key,
const BoundNetLog& net_log);
« no previous file with comments | « net/spdy/spdy_stream_unittest.cc ('k') | net/spdy/spdy_test_util_common.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698