net/quic/quic_network_transaction_unittest.cc - Issue 1298253002: Remove reference counting from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_network_transaction_unittest.cc

diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc

index 1bac0f4816bb8e6907fbd9c26f43f28edd66a4e7..9411ccb756b926b37d2e71091f941cb617c8817b 100644

--- a/net/quic/quic_network_transaction_unittest.cc

+++ b/net/quic/quic_network_transaction_unittest.cc

@@ -319,7 +319,7 @@ class QuicNetworkTransactionTest

params_.next_protos = NextProtosWithSpdyAndQuic(true, true);

}

- session_ = new HttpNetworkSession(params_);

+ session_.reset(new HttpNetworkSession(params_));

session_->quic_stream_factory()->set_require_confirmation(false);

ASSERT_EQ(params_.quic_socket_receive_buffer_size,

session_->quic_stream_factory()->socket_receive_buffer_size());

@@ -426,7 +426,7 @@ class QuicNetworkTransactionTest

MockClock* clock_; // Owned by QuicStreamFactory after CreateSession.

QuicTestPacketMaker maker_;

- scoped_refptr<HttpNetworkSession> session_;

+ scoped_ptr<HttpNetworkSession> session_;

MockClientSocketFactory socket_factory_;

MockCryptoClientStreamFactory crypto_client_stream_factory_;

MockHostResolver host_resolver_;

« no previous file with comments | « net/quic/quic_end_to_end_unittest.cc ('k') | net/socket/ssl_client_socket_pool_unittest.cc » ('j') | no next file with comments »