Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: net/http/http_network_session.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_layer_unittest.cc ('k') | net/http/http_network_session_peer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.h
diff --git a/net/http/http_network_session.h b/net/http/http_network_session.h
index c0503c9f73c26f44879eb18651b5cae6ca052232..7813708927ac5a207bc50b3fb13043d9bbab0b32 100644
--- a/net/http/http_network_session.h
+++ b/net/http/http_network_session.h
@@ -57,8 +57,7 @@ class TransportSecurityState;
// This class holds session objects used by HttpNetworkTransaction objects.
class NET_EXPORT HttpNetworkSession
- : public base::RefCounted<HttpNetworkSession>,
- NON_EXPORTED_BASE(public base::NonThreadSafe) {
+ : NON_EXPORTED_BASE(public base::NonThreadSafe) {
public:
struct NET_EXPORT Params {
Params();
@@ -141,6 +140,7 @@ class NET_EXPORT HttpNetworkSession
};
explicit HttpNetworkSession(const Params& params);
+ ~HttpNetworkSession();
HttpAuthCache* http_auth_cache() { return &http_auth_cache_; }
SSLClientAuthCache* ssl_client_auth_cache() {
@@ -213,11 +213,8 @@ class NET_EXPORT HttpNetworkSession
bool HasSpdyExclusion(HostPortPair host_port_pair) const;
private:
- friend class base::RefCounted<HttpNetworkSession>;
friend class HttpNetworkSessionPeer;
- ~HttpNetworkSession();
-
ClientSocketPoolManager* GetSocketPoolManager(SocketPoolType pool_type);
NetLog* const net_log_;
« no previous file with comments | « net/http/http_network_layer_unittest.cc ('k') | net/http/http_network_session_peer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698