Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: net/http/http_cache.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert_net/cert_net_fetcher_impl_unittest.cc ('k') | net/http/http_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_cache.h
diff --git a/net/http/http_cache.h b/net/http/http_cache.h
index 026d476e92f0dcfd36c309d07c5016ddfaa04854..286c67087d78377c10026da4794bfcd02d5af8b1 100644
--- a/net/http/http_cache.h
+++ b/net/http/http_cache.h
@@ -126,23 +126,26 @@ class NET_EXPORT HttpCache : public HttpTransactionFactory,
static const int kPrefetchReuseMins = 5;
// The disk cache is initialized lazily (by CreateTransaction) in this case.
- // The HttpCache takes ownership of the |backend_factory|.
- HttpCache(const HttpNetworkSession::Params& params,
- BackendFactory* backend_factory);
-
- // The disk cache is initialized lazily (by CreateTransaction) in this case.
// Provide an existing HttpNetworkSession, the cache can construct a
// network layer with a shared HttpNetworkSession in order for multiple
// network layers to share information (e.g. authentication data). The
// HttpCache takes ownership of the |backend_factory|.
- HttpCache(HttpNetworkSession* session, BackendFactory* backend_factory);
+ //
+ // The HttpCache must be destroyed before the HttpNetworkSession.
+ //
+ // If |set_up_quic_server_info| is true, configures the cache to track
+ // information about servers supporting QUIC.
+ HttpCache(HttpNetworkSession* session,
+ BackendFactory* backend_factory,
+ bool set_up_quic_server_info);
// Initialize the cache from its component parts. The lifetime of the
// |network_layer| and |backend_factory| are managed by the HttpCache and
// will be destroyed using |delete| when the HttpCache is destroyed.
HttpCache(HttpTransactionFactory* network_layer,
NetLog* net_log,
- BackendFactory* backend_factory);
+ BackendFactory* backend_factory,
+ bool set_up_quic_server_info);
~HttpCache() override;
« no previous file with comments | « net/cert_net/cert_net_fetcher_impl_unittest.cc ('k') | net/http/http_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698