components/gcm_driver/gcm_client.h - Issue 1298253002: Remove reference counting from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_client.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/gcm_driver/gcm_client.h

diff --git a/components/gcm_driver/gcm_client.h b/components/gcm_driver/gcm_client.h

index 0aa9a1a8f7520a73d885476f56a81e937ee6e3a0..5f7f293d7f144a6365732f287e61e2d536a71507 100644

--- a/components/gcm_driver/gcm_client.h

+++ b/components/gcm_driver/gcm_client.h

@@ -217,9 +217,10 @@ class GCMClient {

// |chrome_build_info|: chrome info, i.e., version, channel and etc.

// |store_path|: path to the GCM store.

// |blocking_task_runner|: for running blocking file tasks.

- // |url_request_context_getter|: for url requests.

+ // |url_request_context_getter|: for url requests. The GCMClient must be

+ // deleted before the Getter's underlying URLRequestContext.

// |delegate|: the delegate whose methods will be called asynchronously in

- // response to events and messages.

+ // response to events and messages.

virtual void Initialize(

const ChromeBuildInfo& chrome_build_info,

const base::FilePath& store_path,

« no previous file with comments | « chrome/browser/profiles/profile_io_data.cc ('k') | components/gcm_driver/gcm_client_impl.h » ('j') | no next file with comments »