net/url_request/url_request_test_util.cc - Issue 1298253002: Remove reference counting from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_test_util.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed two comments, fix some tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_test_util.cc

diff --git a/net/url_request/url_request_test_util.cc b/net/url_request/url_request_test_util.cc

index 269203489f9f8c64580acec3836c3647a933ac19..e692c8f4892f06d283fd9bbfc11e5b3fb148e78f 100644

--- a/net/url_request/url_request_test_util.cc

+++ b/net/url_request/url_request_test_util.cc

@@ -111,9 +111,11 @@ void TestURLRequestContext::Init() {

params.network_delegate = network_delegate();

params.http_server_properties = http_server_properties();

params.net_log = net_log();

- context_storage_.set_http_transaction_factory(new HttpCache(

- new HttpNetworkSession(params),

- HttpCache::DefaultBackend::InMemory(0)));

+ context_storage_.set_http_network_session(

+ make_scoped_ptr(new HttpNetworkSession(params)));

+ context_storage_.set_http_transaction_factory(

+ new HttpCache(context_storage_.http_network_session(),

+ HttpCache::DefaultBackend::InMemory(0), false));

}

// In-memory cookie store.

if (!cookie_store())