Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed too much, back up a bit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index da340ea4a49ae6d02a5b0310b2d6461dd3e74ee5..346f0e52b3567569fdbf748bc5c28856fbaf1c18 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -7031,12 +7031,14 @@ TEST_F(URLRequestTestHTTP, NetworkSuspendTest) {
default_context_.http_auth_handler_factory();
params.network_delegate = &default_network_delegate_;
params.http_server_properties = default_context_.http_server_properties();
+ scoped_ptr<HttpNetworkSession> network_session(
+ new HttpNetworkSession(params));
scoped_ptr<HttpNetworkLayer> network_layer(
- new HttpNetworkLayer(new HttpNetworkSession(params)));
+ new HttpNetworkLayer(network_session.get()));
network_layer->OnSuspend();
HttpCache http_cache(network_layer.release(), default_context_.net_log(),
- HttpCache::DefaultBackend::InMemory(0));
+ HttpCache::DefaultBackend::InMemory(0), true);
pauljensen 2015/09/02 14:32:30 Can you explain your logic for setting set_up_quic
mmenke 2015/09/02 16:29:34 I tried to keep the existing logic. If the old co
TestURLRequestContext context(true);
context.set_http_transaction_factory(&http_cache);
@@ -8080,9 +8082,10 @@ TEST_F(HTTPSRequestTest, SSLSessionCacheShardTest) {
params.http_server_properties = default_context_.http_server_properties();
params.ssl_session_cache_shard = "alternate";
+ scoped_ptr<HttpNetworkSession> network_session(
+ new HttpNetworkSession(params));
scoped_ptr<HttpCache> cache(new HttpCache(
- new HttpNetworkSession(params),
- HttpCache::DefaultBackend::InMemory(0)));
+ network_session.get(), HttpCache::DefaultBackend::InMemory(0), false));
default_context_.set_http_transaction_factory(cache.get());

Powered by Google App Engine
This is Rietveld 408576698