ios/web/shell/shell_url_request_context_getter.cc - Issue 1298253002: Remove reference counting from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/shell/shell_url_request_context_getter.cc

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed too much, back up a bit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/shell/shell_url_request_context_getter.cc

diff --git a/ios/web/shell/shell_url_request_context_getter.cc b/ios/web/shell/shell_url_request_context_getter.cc

index 5d8c660357c7d642b569e7dd97d21db546507846..f0b4185a135e07d8d70071505c5025bc174e63fc 100644

--- a/ios/web/shell/shell_url_request_context_getter.cc

+++ b/ios/web/shell/shell_url_request_context_getter.cc

@@ -135,8 +135,10 @@ net::URLRequestContext* ShellURLRequestContextGetter::GetURLRequestContext() {

net::CACHE_BACKEND_DEFAULT,

cache_path, 0, cache_task_runner_);

- net::HttpCache* main_cache =

- new net::HttpCache(network_session_params, main_backend);

+ storage_->set_http_network_session(

+ make_scoped_ptr(new net::HttpNetworkSession(network_session_params)));

pauljensen 2015/09/02 14:32:29 FYI this will conflict with https://codereview.chr

mmenke 2015/09/02 16:29:33 Acknowledged.

+ net::HttpCache* main_cache = new net::HttpCache(

+ storage_->http_network_session(), main_backend, true);

storage_->set_http_transaction_factory(main_cache);

scoped_ptr<net::URLRequestJobFactoryImpl> job_factory(