Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: android_webview/browser/net/aw_url_request_context_getter.h

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed too much, back up a bit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/aw_url_request_context_getter.h
diff --git a/android_webview/browser/net/aw_url_request_context_getter.h b/android_webview/browser/net/aw_url_request_context_getter.h
index a7713fe83c0287bd001a807ab5599005419ea8dc..868a67019232113806594958bfdb1739b99407c4 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.h
+++ b/android_webview/browser/net/aw_url_request_context_getter.h
@@ -65,13 +65,15 @@ class AwURLRequestContextGetter : public net::URLRequestContextGetter {
void InitializeURLRequestContext();
const base::FilePath cache_path_;
- scoped_refptr<net::CookieStore> cookie_store_;
+
scoped_ptr<net::NetLog> net_log_;
pauljensen 2015/09/02 14:32:29 I like how you've reordered this here to better ma
mmenke 2015/09/02 16:29:33 I think it makes sense, but is a bit beyond the sc
- scoped_ptr<net::URLRequestContext> url_request_context_;
scoped_ptr<net::ProxyConfigService> proxy_config_service_;
- scoped_ptr<net::URLRequestJobFactory> job_factory_;
+ scoped_ptr<net::HttpNetworkSession> http_network_session_;
scoped_ptr<net::HttpTransactionFactory> main_http_factory_;
+ scoped_refptr<net::CookieStore> cookie_store_;
+ scoped_ptr<net::URLRequestJobFactory> job_factory_;
scoped_ptr<net::HttpUserAgentSettings> http_user_agent_settings_;
+ scoped_ptr<net::URLRequestContext> url_request_context_;
// ProtocolHandlers and interceptors are stored here between
// SetHandlersAndInterceptors() and the first GetURLRequestContext() call.

Powered by Google App Engine
This is Rietveld 408576698