Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/crnet/crnet_environment.mm

Issue 1298253002: Remove reference counting from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add scary comment Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/gcm_driver/gcm_client_impl.cc ('K') | « google_apis/gcm/tools/mcs_probe.cc ('k') | ios/web/shell/shell_url_request_context_getter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/crnet/crnet_environment.mm
diff --git a/ios/crnet/crnet_environment.mm b/ios/crnet/crnet_environment.mm
index 3eb873a1f081d1778b2e7c67710d9d22230e8ef6..06c2776e7ad3426c80b6b0c07cf40ebf9ecaa80b 100644
--- a/ios/crnet/crnet_environment.mm
+++ b/ios/crnet/crnet_environment.mm
@@ -446,7 +446,11 @@ void CrNetEnvironment::InitializeOnNetworkThread() {
base::WorkerPool::GetTaskRunner(true));
}
- net::HttpCache* main_cache = new net::HttpCache(params, main_backend);
+ // TODO(mmenke): These really shouldn't be leaked.
+ net::HttpNetworkSession* http_network_session =
+ new net::HttpNetworkSession(params);
+ net::HttpCache* main_cache = new net::HttpCache(
+ http_network_session, main_backend, true);
main_context_->set_http_transaction_factory(main_cache);
// Cookies
« components/gcm_driver/gcm_client_impl.cc ('K') | « google_apis/gcm/tools/mcs_probe.cc ('k') | ios/web/shell/shell_url_request_context_getter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698