Remove reference counting from HttpNetworkSession.

components/gcm_driver/gcm_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_
 #define COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 199 matching lines @@
   };
 
   GCMClient();
   virtual ~GCMClient();
 
   // Begins initialization of the GCM Client. This will not trigger a
   // connection.
   // |chrome_build_info|: chrome info, i.e., version, channel and etc.
   // |store_path|: path to the GCM store.
   // |blocking_task_runner|: for running blocking file tasks.
-  // |url_request_context_getter|: for url requests.
+  // |url_request_context_getter|: for url requests. The GCMClient must be
+  //     deleted before the Getter's underlying URLRequestContext.

[mmenke, 2015/08/31 15:55:56]

This may seem like a scary new requirement, but we're actually already depending
on it.  The HttpNetworkSession may nominally have been refcounted, but it wasn't
safe to use after ProfileIOData was deleting, since HttpNetworkSession::Params
contains a bunch of raw pointers.

[Nicolas Zea, 2015/08/31 19:43:28]

Acknowledged.

   // |delegate|: the delegate whose methods will be called asynchronously in
-  //             response to events and messages.
+  //     response to events and messages.
   virtual void Initialize(
       const ChromeBuildInfo& chrome_build_info,
       const base::FilePath& store_path,
       const scoped_refptr<base::SequencedTaskRunner>& blocking_task_runner,
       const scoped_refptr<net::URLRequestContextGetter>&
           url_request_context_getter,
       scoped_ptr<Encryptor> encryptor,
       Delegate* delegate) = 0;
 
   // This will initiate the GCM connection only if |start_mode| means to start
@@ skipping 80 matching lines @@
   // to be set, and allows that component to later revoke the setting. It should
   // be unique.
   virtual void AddHeartbeatInterval(const std::string& scope,
                                     int interval_ms) = 0;
   virtual void RemoveHeartbeatInterval(const std::string& scope) = 0;
 };
 
 }  // namespace gcm
 
 #endif  // COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_