SkPDF/Deflate: clean up old SkFlate code

SkPDF/Deflate: clean up old SkFlate code

Factor out some of https://crrev.com/1227913008

BUG=skia:3030
Committed: https://skia.googlesource.com/skia/+/48305e835351291ef72a7084c6c1af7b185d89c0

[hal.canary, 2015-08-18 19:19:58]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-18 19:20:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298243002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298243002/1

[hal.canary, 2015-08-18 19:25:04]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-08-18 19:25:05]

PTAL

[commit-bot: I haz the power, 2015-08-18 19:26:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 19:26:31]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2015-08-18 19:33:08]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2015-08-18 19:33:09]

https://codereview.chromium.org/1298243002/diff/1/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/1298243002/diff/1/src/core/SkStream.cpp#newco...
src/core/SkStream.cpp:963: char scratch[4096];
Let's make sure this path is tested too.

https://codereview.chromium.org/1298243002/diff/1/src/pdf/SkDeflate.cpp
File src/pdf/SkDeflate.cpp (right):

https://codereview.chromium.org/1298243002/diff/1/src/pdf/SkDeflate.cpp#newco...
src/pdf/SkDeflate.cpp:23: const size_t kBufferSize = 1024;
Make this and skia_alloc_func() actually static, then remove the namespace {}? 
It's sort of stuttery to mix namespace {} and static together.

https://codereview.chromium.org/1298243002/diff/1/src/pdf/SkDeflate.h
File src/pdf/SkDeflate.h (right):

https://codereview.chromium.org/1298243002/diff/1/src/pdf/SkDeflate.h#newcode21
src/pdf/SkDeflate.h:21: SkStreamAsset* SkInflate(SkStream* src);
If only used for testing, let's move it out of src/.

[hal.canary, 2015-08-18 20:06:23]

https://codereview.chromium.org/1298243002/diff/1/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/1298243002/diff/1/src/core/SkStream.cpp#newco...
src/core/SkStream.cpp:963: char scratch[4096];
On 2015/08/18 19:33:09, mtklein_C wrote:
> Let's make sure this path is tested too.

Done.

https://codereview.chromium.org/1298243002/diff/1/src/pdf/SkDeflate.cpp
File src/pdf/SkDeflate.cpp (right):

https://codereview.chromium.org/1298243002/diff/1/src/pdf/SkDeflate.cpp#newco...
src/pdf/SkDeflate.cpp:23: const size_t kBufferSize = 1024;
On 2015/08/18 19:33:09, mtklein_C wrote:
> Make this and skia_alloc_func() actually static, then remove the namespace {}?

> It's sort of stuttery to mix namespace {} and static together.

Acknowledged.

https://codereview.chromium.org/1298243002/diff/1/src/pdf/SkDeflate.h
File src/pdf/SkDeflate.h (right):

https://codereview.chromium.org/1298243002/diff/1/src/pdf/SkDeflate.h#newcode21
src/pdf/SkDeflate.h:21: SkStreamAsset* SkInflate(SkStream* src);
On 2015/08/18 19:33:09, mtklein_C wrote:
> If only used for testing, let's move it out of src/.

Done.

Moved to tests/PDFDeflateWStreamTest.cpp

[mtklein_C, 2015-08-18 20:13:35]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2015-08-18 20:13:36]

lgtm

https://codereview.chromium.org/1298243002/diff/20001/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/1298243002/diff/20001/src/core/SkStream.cpp#n...
src/core/SkStream.cpp:957: // Shortcut that avoids the do-while loop.
while?

[mtklein_C, 2015-08-18 20:13:38]

The CQ bit was unchecked by mtklein@chromium.org

[hal.canary, 2015-08-18 20:19:52]

https://codereview.chromium.org/1298243002/diff/20001/src/core/SkStream.cpp
File src/core/SkStream.cpp (right):

https://codereview.chromium.org/1298243002/diff/20001/src/core/SkStream.cpp#n...
src/core/SkStream.cpp:957: // Shortcut that avoids the do-while loop.
On 2015/08/18 20:13:35, mtklein_C wrote:
> while?

Done.

https://codereview.chromium.org/1298243002/diff/40001/tests/StreamTest.cpp
File tests/StreamTest.cpp (right):

https://codereview.chromium.org/1298243002/diff/40001/tests/StreamTest.cpp#ne...
tests/StreamTest.cpp:389: // SkStreamCopy had two code paths; this test both.
I also expanded this test.

[hal.canary, 2015-08-18 20:20:22]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-08-18 20:20:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@chromium.org
Link to the patchset: https://codereview.chromium.org/1298243002/#ps40001
(title: "2015-08-18 (Tuesday) 16:19:01 EDT")

[commit-bot: I haz the power, 2015-08-18 20:20:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298243002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298243002/40001

[commit-bot: I haz the power, 2015-08-18 20:30:29]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/48305e835351291ef72a7084c6c1af7b185d89c0