Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1298213002: Add skeleton json support to visualbench (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add skeleton json support to visualbench BUG=skia: Committed: https://skia.googlesource.com/skia/+/892b0c3db996e61a5a92c008d8706d87f5c288cf

Patch Set 1 #

Patch Set 2 : delete newline #

Total comments: 2

Patch Set 3 : feedback inc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -3 lines) Patch
M gyp/visualbench.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/VisualBench/VisualBench.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M tools/VisualBench/VisualBench.cpp View 1 2 5 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-18 17:53:20 UTC) #3
robertphillips
lgtm + a question https://codereview.chromium.org/1298213002/diff/20001/tools/VisualBench/VisualBench.cpp File tools/VisualBench/VisualBench.cpp (right): https://codereview.chromium.org/1298213002/diff/20001/tools/VisualBench/VisualBench.cpp#newcode159 tools/VisualBench/VisualBench.cpp:159: SkString configName; < 0 ?
5 years, 4 months ago (2015-08-18 17:57:40 UTC) #4
borenet
https://codereview.chromium.org/1298213002/diff/20001/tools/VisualBench/VisualBench.h File tools/VisualBench/VisualBench.h (right): https://codereview.chromium.org/1298213002/diff/20001/tools/VisualBench/VisualBench.h#newcode110 tools/VisualBench/VisualBench.h:110: SkAutoTDelete<ResultsWriter> fLog; IMO something like "fResults" would be more ...
5 years, 4 months ago (2015-08-18 17:57:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298213002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298213002/40001
5 years, 4 months ago (2015-08-18 19:04:29 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 19:13:36 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/892b0c3db996e61a5a92c008d8706d87f5c288cf

Powered by Google App Engine
This is Rietveld 408576698