Review changes

runtime/lib/byte_array.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/exceptions.h"
@@ skipping 233 matching lines @@
 DEFINE_NATIVE_ENTRY(ByteArray_getUint64, 2) {
   UNALIGNED_GETTER_UINT64(ByteArray);
 }
 
 
 DEFINE_NATIVE_ENTRY(ByteArray_setUint64, 3) {
   UNALIGNED_SETTER_UINT64(ByteArray);
 }
 
 
-DEFINE_NATIVE_ENTRY(ByteArray_getFloat32x4, 2) {
-  UNALIGNED_GETTER(ByteArray, Float32x4, simd128_value_t);
-}
-
-
-DEFINE_NATIVE_ENTRY(ByteArray_setFloat32x4, 3) {
-  UNALIGNED_SETTER(ByteArray, Float32x4, value, simd128_value_t);
-}
-
-
 DEFINE_NATIVE_ENTRY(ByteArray_getFloat32, 2) {
   UNALIGNED_GETTER(ByteArray, Double, float);
 }
 
 
 DEFINE_NATIVE_ENTRY(ByteArray_setFloat32, 3) {
   UNALIGNED_SETTER(ByteArray, Double, value, float);
 }
 
 
@@ skipping 325 matching lines @@
 
 DEFINE_NATIVE_ENTRY(Uint64Array_getIndexed, 2) {
   GETTER_UINT64(Uint64Array);
 }
 
 
 DEFINE_NATIVE_ENTRY(Uint64Array_setIndexed, 3) {
   SETTER_UINT64(Uint64Array);
 }
 
-// Float32x4Array
-
-DEFINE_NATIVE_ENTRY(Float32x4Array_new, 1) {
-  GET_NON_NULL_NATIVE_ARGUMENT(Smi, length, arguments->NativeArgAt(0));
-  intptr_t len = length.Value();
-  LengthCheck(len, Float32x4Array::kMaxElements);
-  return Float32x4Array::New(len);
-}
-
-
-DEFINE_NATIVE_ENTRY(Float32x4List_newTransferable, 1) {
-  const int kAlignment = 16;
-  GET_NON_NULL_NATIVE_ARGUMENT(Smi, length, arguments->NativeArgAt(0));
-  intptr_t len = length.Value();
-  LengthCheck(len, Float32x4Array::kMaxElements);
-  simd128_value_t* bytes =
-      OS::AllocateAlignedArray<simd128_value_t>(len, kAlignment);
-  const ExternalFloat32x4Array& obj =
-      ExternalFloat32x4Array::Handle(ExternalFloat32x4Array::New(bytes, len));
-  obj.AddFinalizer(bytes, PeerFinalizer);
-  return obj.raw();
-}
-
-
-DEFINE_NATIVE_ENTRY(Float32x4Array_getIndexed, 2) {
-  GETTER(Float32x4Array, Float32x4, simd128_value_t);
-}
-
-
-DEFINE_NATIVE_ENTRY(Float32x4Array_setIndexed, 3) {
-  SETTER(Float32x4Array, Float32x4, value, simd128_value_t);
-}
-
 
 // Float32Array
 
 DEFINE_NATIVE_ENTRY(Float32Array_new, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Smi, length, arguments->NativeArgAt(0));
   intptr_t len = length.Value();
   LengthCheck(len, Float32Array::kMaxElements);
   return Float32Array::New(len);
 }
 
@@ skipping 155 matching lines @@
 DEFINE_NATIVE_ENTRY(ExternalUint64Array_getIndexed, 2) {
   GETTER_UINT64(ExternalUint64Array);
 }
 
 
 DEFINE_NATIVE_ENTRY(ExternalUint64Array_setIndexed, 3) {
   SETTER_UINT64(ExternalUint64Array);
 }
 
 
-// ExternalFloat32x4Array
-
-DEFINE_NATIVE_ENTRY(ExternalFloat32x4Array_getIndexed, 2) {
-  GETTER(ExternalFloat32x4Array, Float32x4, simd128_value_t);
-}
-
-
-DEFINE_NATIVE_ENTRY(ExternalFloat32x4Array_setIndexed, 3) {
-  SETTER(ExternalFloat32x4Array, Float32x4, value, simd128_value_t);
-}
-
-
 // ExternalFloat32Array
 
 DEFINE_NATIVE_ENTRY(ExternalFloat32Array_getIndexed, 2) {
   GETTER(ExternalFloat32Array, Double, float);
 }
 
 
 DEFINE_NATIVE_ENTRY(ExternalFloat32Array_setIndexed, 3) {
   SETTER(ExternalFloat32Array, Double, value, float);
 }
 
 
 // ExternalFloat64Array
 
 DEFINE_NATIVE_ENTRY(ExternalFloat64Array_getIndexed, 2) {
   GETTER(ExternalFloat64Array, Double, double);
 }
 
 
 DEFINE_NATIVE_ENTRY(ExternalFloat64Array_setIndexed, 3) {
   SETTER(ExternalFloat64Array, Double, value, double);
 }
 
 }  // namespace dart