LayoutTests/fast/css/getComputedStyle/computed-style-redistribution.html - Issue 1298173004: Implement proposed shadow tree cascade order.

Side by Side Diff: LayoutTests/fast/css/getComputedStyle/computed-style-redistribution.html

Issue 1298173004: Implement proposed shadow tree cascade order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed review issues Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css/deep-cascade-order.html ('K') | « LayoutTests/fast/css/deep-cascade-order-expected.txt ('k') | LayoutTests/fast/dom/shadow/cascade-of-treeboundary-crossing-rules.html » ('j') | Source/core/css/resolver/StyleResolver.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <style>	3 <style>

4 .d1, .d2 { color: red }	4 custom-element { color: red }
	kochi 2015/08/20 13:10:02 My understanding is that the previous selector (.d My understanding is that the previous selector (.d1, .d2) was weaker than one in the shadow (::content div), but with this change outer one wins, but if you replace ".d1, .d2" with "custom-element", the <div>s are styled via inheritance from custom-element, so always the style from shadow (::content div) wins, right? I think this change doesn't change what this test was meant to be, so IIUC this change is okay. rune 2015/08/21 07:37:46 You're right. I had to change the control style fo Show quoted text On 2015/08/20 13:10:02, Takayoshi Kochi wrote: > My understanding is that the previous selector (.d1, .d2) was weaker > than one in the shadow (::content div), but with this change outer one wins, > but if you replace ".d1, .d2" with "custom-element", the <div>s are > styled via inheritance from custom-element, so always the style from > shadow (::content div) wins, right? > > I think this change doesn't change what this test was meant to be, so IIUC > this change is okay. You're right. I had to change the control style for red because the outer-wins bugfix would otherwise always make this red.
5 </style>	5 </style>

6 <custom-element>	6 <custom-element>

7 <div class="d1">A</div>	7 <div class="d1">A</div>

8 <div class="d2">B</div>	8 <div class="d2">B</div>

9 </custom-element>	9 </custom-element>

10 <script>	10 <script>

11 description("Check that getComputedStyle causes a shadow re-distribution when ne cessary.");	11 description("Check that getComputedStyle causes a shadow re-distribution when ne cessary.");

12	12

13 var red = "rgb(255, 0, 0)";	13 var red = "rgb(255, 0, 0)";

14 var green = "rgb(0, 128, 0)";	14 var green = "rgb(0, 128, 0)";

15	15

16 var custom = document.querySelector("custom-element");	16 var custom = document.querySelector("custom-element");

17 var shadowRoot = custom.createShadowRoot();	17 var shadowRoot = custom.createShadowRoot();

18 shadowRoot.innerHTML = '<style>::content div { color: green; }</style><content s elect=".d2"><content>'	18 shadowRoot.innerHTML = '<style>::content div { color: green; }</style><content s elect=".d2"><content>'

19	19

20 var d1 = document.querySelector(".d1");	20 var d1 = document.querySelector(".d1");

21 var d2 = document.querySelector(".d2");	21 var d2 = document.querySelector(".d2");

22	22

23 shouldBe("getComputedStyle(d1).color", "red");	23 shouldBe("getComputedStyle(d1).color", "red");

24 shouldBe("getComputedStyle(d2).color", "green");	24 shouldBe("getComputedStyle(d2).color", "green");

25	25

26 document.body.offsetTop;	26 document.body.offsetTop;

27	27

28 shadowRoot.querySelector("content").setAttribute("select", ".d1");	28 shadowRoot.querySelector("content").setAttribute("select", ".d1");

29	29

30 shouldBe("getComputedStyle(d1).color", "green");	30 shouldBe("getComputedStyle(d1).color", "green");

31 shouldBe("getComputedStyle(d2).color", "red");	31 shouldBe("getComputedStyle(d2).color", "red");

32	32

33 </script>	33 </script>

OLD	NEW