LayoutTests/fast/css/deep-cascade-order.html - Issue 1298173004: Implement proposed shadow tree cascade order.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/deep-cascade-order.html

Issue 1298173004: Implement proposed shadow tree cascade order. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed review issues Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/css/content-distributed-nodes-expected.txt ('k') | LayoutTests/fast/css/deep-cascade-order-expected.txt » ('j') | LayoutTests/fast/css/getComputedStyle/computed-style-redistribution.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <style>

	4 .host1 /deep/ div { color: green }

	5 #host2 /deep/ div { color: red !important }

	6 </style>

	7 <div id="host1" class="host1"></div>

	8 <div id="host2" class="host2"></div>

	9 <script>

	10 description("Cascade order for inner/outer tree rules with /deep/.");

	11

	12 var root1 = host1.createShadowRoot();

	13 root1.innerHTML = '<style>#d1 {color:red}</style><div id="d1">Should be gree n</div><div style="color: red">Should be green</div>';

	14

	15 var root2 = host2.createShadowRoot();

	16 root2.innerHTML = '<style>.d1 {color:green !important}</style><div class="d1 ">Should be green</div><div style="color: green !important">Should be green</div >';

	17

	18 var green = "rgb(0, 128, 0)";

	19

	20 shouldBe("getComputedStyle(root1.querySelector('div')).color", "green");

	21

	22 debug("Currently fails because style attributes are added to the end, not in its element's scope's cascade order");
	kochi 2015/08/20 13:10:02 Could you add TODO(rune) here? Could you add TODO(rune) here? rune 2015/08/21 07:37:46 Done. Show quoted text On 2015/08/20 13:10:02, Takayoshi Kochi wrote: > Could you add TODO(rune) here? Done.
	23 shouldBe("getComputedStyle(root1.querySelector('div + div')).color", "green" );

	24

	25 shouldBe("getComputedStyle(root2.querySelector('div')).color", "green");

	26

	27 debug("Currently fails because style attributes are added to the end, not in its element's scope's cascade order");

	28 shouldBe("getComputedStyle(root2.querySelector('div + div')).color", "green" );

	29 </script>

OLD	NEW