LayoutTests/fast/events/touch/touch-rect-assert-first-layer-special.html - Issue 129813009: Fix RenderGeometryMap ASSERT in touch hit rect computation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/touch/touch-rect-assert-first-layer-special.html

Issue 129813009: Fix RenderGeometryMap ASSERT in touch hit rect computation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <style>

	5 /* By applying a transform to the html element, we ensure that

	6 RenderGeometryMap::pushMappingsToAncestor takes the slow bath (which doesn't pus h

	7 the RenderView */

	8 html {

	9 -webkit-transform: scale(1.1);

	10 }

	11 </style>

	12 <script src="../../../resources/js-test.js"></script>

	13 </head>

	14 <body>

	15 <p id="description"></p>

	16 <div id="console"></div>

	17 <div id="touchtarget" ontouchstart="alert()">Foo</div>
	leviw_travelin_and_unemployed 2014/01/30 03:13:01 Why the alert? If it's for manual testing, you may Why the alert? If it's for manual testing, you may want to mention it in the description.
	18 <script>

	19 description("Make sure we don't ASSERT when the first layer is special and c an't use the RenderGeometryMap fast path - crbug.com/339141.");

	20

	21 if (window.internals) {
	leviw_travelin_and_unemployed 2014/01/30 03:13:01 Nit: braces for one-line if statement. Nit: braces for one-line if statement.
	22 window.internals.settings.setForceCompositingMode(true);

	23 }

	24

	25 var rects;

	26 // Verify we actually have a hit rect in the document.

	27 if (window.internals) {

	28 rects = window.internals.touchEventTargetLayerRects(document);

	29 shouldBe("rects.length", "1");

	30 shouldBeEqualToString("rects[0].layerRootNode.nodeName", "#document");

	31 }

	32 </script>

	33 </body>

	34 </html>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | no next file with comments »