Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: content/renderer/render_view_impl.cc

Issue 129813006: Move DidReceiveServerRedirectForProvisionalLoad from RenderView to RenderFrame (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix layout test failures. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/shell/renderer/test_runner/WebFrameTestProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 0faf36066e10857dc89878d83f761325abf07c14..ef9ed17ef8624a763bd5971c33cc8d5cc8bd29a5 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -372,20 +372,6 @@ const size_t kContentIntentDelayMilliseconds = 700;
static RenderViewImpl* (*g_create_render_view_impl)(RenderViewImplParams*) =
NULL;
-static void GetRedirectChain(WebDataSource* ds, std::vector<GURL>* result) {
- // Replace any occurrences of swappedout:// with about:blank.
- const WebURL& blank_url = GURL(kAboutBlankURL);
- WebVector<WebURL> urls;
- ds->redirectChain(urls);
- result->reserve(urls.size());
- for (size_t i = 0; i < urls.size(); ++i) {
- if (urls[i] != GURL(kSwappedOutURL))
- result->push_back(urls[i]);
- else
- result->push_back(blank_url);
- }
-}
-
// If |data_source| is non-null and has an InternalDocumentStateData associated
// with it, the AltErrorPageResourceFetcher is reset.
static void StopAltErrorPageFetcher(WebDataSource* data_source) {
@@ -406,6 +392,22 @@ static bool IsReload(const ViewMsg_Navigate_Params& params) {
}
// static
+void RenderViewImpl::GetRedirectChain(WebDataSource* ds,
+ std::vector<GURL>* result) {
+ // Replace any occurrences of swappedout:// with about:blank.
+ const WebURL& blank_url = GURL(kAboutBlankURL);
+ WebVector<WebURL> urls;
+ ds->redirectChain(urls);
+ result->reserve(urls.size());
+ for (size_t i = 0; i < urls.size(); ++i) {
+ if (urls[i] != GURL(kSwappedOutURL))
+ result->push_back(urls[i]);
+ else
+ result->push_back(blank_url);
+ }
+}
+
+// static
WebReferrerPolicy RenderViewImpl::GetReferrerPolicyFromRequest(
WebFrame* frame,
const WebURLRequest& request) {
@@ -3536,25 +3538,6 @@ void RenderViewImpl::ProcessViewLayoutFlags(const CommandLine& command_line) {
void RenderViewImpl::didStartProvisionalLoad(WebFrame* frame) {
}
-void RenderViewImpl::didReceiveServerRedirectForProvisionalLoad(
- WebFrame* frame) {
- if (frame->parent())
- return;
- // Received a redirect on the main frame.
- WebDataSource* data_source = frame->provisionalDataSource();
- if (!data_source) {
- // Should only be invoked when we have a data source.
- NOTREACHED();
- return;
- }
- std::vector<GURL> redirects;
- GetRedirectChain(data_source, &redirects);
- if (redirects.size() >= 2) {
- Send(new ViewHostMsg_DidRedirectProvisionalLoad(routing_id_, page_id_,
- redirects[redirects.size() - 2], redirects.back()));
- }
-}
-
void RenderViewImpl::didFailProvisionalLoad(WebFrame* frame,
const WebURLError& error) {
// Notify the browser that we failed a provisional load with an error.
« no previous file with comments | « content/renderer/render_view_impl.h ('k') | content/shell/renderer/test_runner/WebFrameTestProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698