[api,heap] Fix external GC callbacks.

include/v8.h

Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 95edfdb10cad504069835b8a87afaca55b5e594d..39868052f84aff3482596962aa512efd5998e854 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4951,16 +4951,19 @@ typedef bool (*AllowCodeGenerationFromStringsCallback)(Local<Context> context);
 // --- Garbage Collection Callbacks ---
 
 /**
- * Applications can register callback functions which will be called
- * before and after a garbage collection.  Allocations are not
- * allowed in the callback functions, you therefore cannot manipulate
- * objects (set or delete properties for example) since it is possible
- * such operations will result in the allocation of objects.
+ * Applications can register callback functions which will be called before and
+ * after certain garbage collection operations.  Allocations are not allowed in
+ * the callback functions, you therefore cannot manipulate objects (set or
+ * delete properties for example) since it is possible such operations will
+ * result in the allocation of objects.
  */
 enum GCType {
   kGCTypeScavenge = 1 << 0,
   kGCTypeMarkSweepCompact = 1 << 1,
-  kGCTypeAll = kGCTypeScavenge | kGCTypeMarkSweepCompact
+  kGCTypeIncremental = 1 << 2,

[Hannes Payer (out of office), 2015/08/18 09:18:13]

kGCTypeIncrementalMarking maybe?

[Michael Lippautz, 2015/08/18 10:03:08]

Done.

+  kGCTypeProcessWeakCallbacks = 1 << 3,
+  kGCTypeAll = kGCTypeScavenge | kGCTypeMarkSweepCompact | kGCTypeIncremental |
+               kGCTypeProcessWeakCallbacks
 };
 
 enum GCCallbackFlags {
@@ -4972,6 +4975,7 @@ enum GCCallbackFlags {
 
 typedef void (*GCPrologueCallback)(GCType type, GCCallbackFlags flags);
 typedef void (*GCEpilogueCallback)(GCType type, GCCallbackFlags flags);
+typedef void (*GCCallback)(GCType type, GCCallbackFlags flags);

[Hannes Payer (out of office), 2015/08/18 09:18:13]

We should deprecated the corresponding API functions.

[Michael Lippautz, 2015/08/18 10:03:08]

The typedefs are completely (read: 100%) compatible, so I cannot add overloaded
methods. I changed the methods to use the new types and added deprecation
warnings to the old ones.

 
 typedef void (*InterruptCallback)(Isolate* isolate, void* data);
 
@@ -5553,6 +5557,8 @@ class V8_EXPORT Isolate {
   typedef void (*GCEpilogueCallback)(Isolate* isolate,
                                      GCType type,
                                      GCCallbackFlags flags);
+  typedef void (*GCCallback)(Isolate* isolate, GCType type,
+                             GCCallbackFlags flags);
 
   /**
    * Enables the host application to receive a notification before a