Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 1298073002: Rename Net.DailyContentLength_DataReductionProxyEnabled_Unknown. (Closed)

Created:
5 years, 4 months ago by Not at Google. Contact bengr
Modified:
5 years, 4 months ago
Reviewers:
bengr, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Net.DailyContentLength_DataReductionProxyEnabled_Unknown. Net.DailyContentLength_DataReductionProxyEnabled_Unknown is accidentally tracking 2 separate metrics in the same histogram. It clashes with the histogram generated by adding the "Unknown" suffix in Net.DailyContentLength_DataReductionProxyEnabled. Moving both histograms to a new name and deprecating the old histograms. Committed: https://crrev.com/8548b8f0558bf516e204cadb0269a8f178a8ab19 Cr-Commit-Position: refs/heads/master@{#344000}

Patch Set 1 #

Patch Set 2 : Rename suffix as well #

Patch Set 3 : Sync to head #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc View 1 4 chunks +9 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Not at Google. Contact bengr
isherman: tools/metrics/histograms/histograms.xml bengr: components/data_reduction_proxy/core/browser/data_reduction_proxy_compression_stats.cc
5 years, 4 months ago (2015-08-17 23:51:24 UTC) #2
Ilya Sherman
histograms lgtm
5 years, 4 months ago (2015-08-18 05:25:26 UTC) #3
bengr
lgtm
5 years, 4 months ago (2015-08-18 17:59:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1298073002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1298073002/40001
5 years, 4 months ago (2015-08-18 19:25:52 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-18 19:35:04 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 19:36:03 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8548b8f0558bf516e204cadb0269a8f178a8ab19
Cr-Commit-Position: refs/heads/master@{#344000}

Powered by Google App Engine
This is Rietveld 408576698