Update BUILD.public a bit.

Update BUILD.public a bit.

 - SSE2 files are unfortunately now mixed-case, _SSE2 or _sse2.
 - Adds lists for SSSE3 and SSE4 files.
 - Remove SkDocument_PDF_None.cpp
 - Remove a few more references to animator.
 - Exclude private headers from HDRS.
 - Formatting and notes.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/d55d13af4f73d00e9d8f95d233f977de3df83d05

[mtklein_C, 2015-08-17 22:10:12]

mtklein@chromium.org changed reviewers:
+ benjaminwagner@google.com

[dogben, 2015-08-18 13:17:52]

lgtm

1 Q below.

https://codereview.chromium.org/1298003007/diff/20001/BUILD.public
File BUILD.public (right):

https://codereview.chromium.org/1298003007/diff/20001/BUILD.public#newcode95
BUILD.public:95: "include/private/*.h",
Do these need to be in SRCS?

[mtklein_C, 2015-08-18 14:35:43]

I think I was confused about what hdrs means.  It looks like it's intended to be
"these are headers that might be needed to compile srcs", which means I need to
put include/private/* back.  So I have.

I've also rebased this on head, so you'll see a couple small changes reflecting
headers that have moved around since yesterday.

[dogben, 2015-08-18 14:43:39]

On 2015/08/18 14:35:43, mtklein_C wrote:
> I think I was confused about what hdrs means.  It looks like it's intended to
be
> "these are headers that might be needed to compile srcs", which means I need
to
> put include/private/* back.  So I have.
> 
> I've also rebased this on head, so you'll see a couple small changes
reflecting
> headers that have moved around since yesterday.

No, hdrs means "these are files that dependent BUILD rules can #include."

If a file in srcs #includes a file, that file should be in either srcs or hdrs.
(Not sure if that's *required* or not right now, but someday it will be.)

OTOH, includes tells the compiler where to find #include paths. (I've never used
this before, so I might be wrong.)

[dogben, 2015-08-18 14:44:25]

On 2015/08/18 14:43:39, Ben Wagner wrote:
> On 2015/08/18 14:35:43, mtklein_C wrote:
> If a file in srcs #includes a file, that file should be in either srcs or
hdrs.

... or in the hdrs of a dependent BUILD rule, of course.

[dogben, 2015-08-18 14:44:56]

On 2015/08/18 14:44:25, Ben Wagner wrote:
> On 2015/08/18 14:43:39, Ben Wagner wrote:
> > On 2015/08/18 14:35:43, mtklein_C wrote:
> > If a file in srcs #includes a file, that file should be in either srcs or
> hdrs.
> 
> ... or in the hdrs of a dependent BUILD rule, of course.

Arrgh, I mean in the hdrs of a BUILD rule listed in deps.

[mtklein_C, 2015-08-18 15:07:08]

On 2015/08/18 14:44:56, Ben Wagner wrote:
> On 2015/08/18 14:44:25, Ben Wagner wrote:
> > On 2015/08/18 14:43:39, Ben Wagner wrote:
> > > On 2015/08/18 14:35:43, mtklein_C wrote:
> > > If a file in srcs #includes a file, that file should be in either srcs or
> > hdrs.
> > 
> > ... or in the hdrs of a dependent BUILD rule, of course.
> 
> Arrgh, I mean in the hdrs of a BUILD rule listed in deps.

Ah, good.  Then include/private/*.h belongs in SRCS I think.  They're used by us
to build Skia, but are not used by clients.  Does this PS 5 look right?

[dogben, 2015-08-18 15:29:38]

https://codereview.chromium.org/1298003007/diff/80001/tools/BUILD.public.expe...
File tools/BUILD.public.expected (left):

https://codereview.chromium.org/1298003007/diff/80001/tools/BUILD.public.expe...
tools/BUILD.public.expected:53: 'include/core/SkEndian.h',
Are these removals from core expected?

[mtklein, 2015-08-18 15:30:26]

On 2015/08/18 15:29:38, Ben Wagner wrote:
>
https://codereview.chromium.org/1298003007/diff/80001/tools/BUILD.public.expe...
> File tools/BUILD.public.expected (left):
> 
>
https://codereview.chromium.org/1298003007/diff/80001/tools/BUILD.public.expe...
> tools/BUILD.public.expected:53: 'include/core/SkEndian.h',
> Are these removals from core expected?

yep.  In fact, Hal's about to land a CL that updates this, so I'll rebase on top
of that and this diff won't be visible here any more.   SkEndian.h moved to
src/core.

[dogben, 2015-08-18 15:31:58]

lgtm

[mtklein_C, 2015-08-18 15:42:37]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2015-08-18 15:42:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
benjaminwagner@google.com
Link to the patchset: https://codereview.chromium.org/1298003007/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-18 15:42:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1298003007/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1298003007/100001

[commit-bot: I haz the power, 2015-08-18 15:51:52]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/d55d13af4f73d00e9d8f95d233f977de3df83d05