Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1297993002: Re-enable ChannelMojo (Closed)

Created:
5 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ChannelMojo Let's see if it sticks this time. BUG=500019 TBR=jam@chromium.org Committed: https://crrev.com/22e18de983b5cba85a7a0ed18abacfcb827d29af Cr-Commit-Position: refs/heads/master@{#343803}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297993002/1
5 years, 4 months ago (2015-08-17 16:37:35 UTC) #2
jam
lgtm
5 years, 4 months ago (2015-08-17 17:39:42 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99029)
5 years, 4 months ago (2015-08-17 19:17:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297993002/1
5 years, 4 months ago (2015-08-17 20:07:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99217)
5 years, 4 months ago (2015-08-17 22:59:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297993002/1
5 years, 4 months ago (2015-08-18 00:16:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 05:11:24 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/22e18de983b5cba85a7a0ed18abacfcb827d29af Cr-Commit-Position: refs/heads/master@{#343803}
5 years, 4 months ago (2015-08-18 05:12:15 UTC) #13
Ken Rockot(use gerrit already)
5 years, 4 months ago (2015-08-21 15:31:02 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1303333002/ by rockot@chromium.org.

The reason for reverting is: Looks like a significant perf regression on cast...

:|

BUG=522094
.

Powered by Google App Engine
This is Rietveld 408576698