Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1297963002: Implemented showing update bubble pop-up on password overriding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index e56cf3f82c8f5f17dc9a7e691f82fe553b465770..04cccef51bd34c8fdb267da195c3e15df6f833e6 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -180,6 +180,9 @@ class PasswordFormManager : public PasswordStoreConsumer {
has_generated_password_ = generated_password;
}
+ // This function returns if the user typed new password for stored account.
vabr (Chromium) 2015/08/17 13:21:46 nit: I would not necessarily blame the user here.
vabr (Chromium) 2015/08/17 13:21:46 Also, I would move the comment from here, and only
dvadym 2015/08/17 14:25:34 Done.
+ bool password_overriden() const { return password_overriden_; }
+
// Returns the pending credentials.
const autofill::PasswordForm& pending_credentials() const {
return pending_credentials_;
@@ -392,6 +395,9 @@ class PasswordFormManager : public PasswordStoreConsumer {
// Whether this form has an auto generated password.
bool has_generated_password_;
+ // Whether the user typed new password for stored account.
+ bool password_overriden_;
vabr (Chromium) 2015/08/17 13:21:46 typo: overridden (double d)
dvadym 2015/08/17 14:25:34 Done.
+
// Set if the user has selected one of the other possible usernames in
// |pending_credentials_|.
base::string16 selected_username_;

Powered by Google App Engine
This is Rietveld 408576698