Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 1297963002: Implemented showing update bubble pop-up on password overriding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
index 8aea0125a479920de444b09574baa0093713edc0..e90c7be2fe0cfacf4f1a3ef43aefb1724b76b6a1 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc
@@ -96,6 +96,7 @@ ManagePasswordsBubbleModel::ManagePasswordsBubbleModel(
origin_ = controller->origin();
state_ = controller->state();
+ password_overriden_ = controller->PasswordOverriden();
if (state_ == password_manager::ui::PENDING_PASSWORD_STATE ||
state_ == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE) {
pending_password_ = controller->PendingPassword();
@@ -336,7 +337,7 @@ bool ManagePasswordsBubbleModel::IsNewUIActive() const {
bool ManagePasswordsBubbleModel::ShouldShowMultipleAccountUpdateUI() const {
return state_ == password_manager::ui::PENDING_PASSWORD_UPDATE_STATE &&
- local_credentials_.size() > 1;
+ local_credentials_.size() > 1 && !password_overriden_;
}
// static
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.h ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698