Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.h

Issue 1297963002: Implemented showing update bubble pop-up on password overriding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments were addressed Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
7 7
8 #include "base/memory/scoped_vector.h" 8 #include "base/memory/scoped_vector.h"
9 #include "base/timer/elapsed_timer.h" 9 #include "base/timer/elapsed_timer.h"
10 #include "chrome/browser/ui/passwords/manage_passwords_state.h" 10 #include "chrome/browser/ui/passwords/manage_passwords_state.h"
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 // Current local forms. 149 // Current local forms.
150 const std::vector<const autofill::PasswordForm*>& GetCurrentForms() const { 150 const std::vector<const autofill::PasswordForm*>& GetCurrentForms() const {
151 return passwords_data_.GetCurrentForms(); 151 return passwords_data_.GetCurrentForms();
152 } 152 }
153 153
154 // Current federated forms. 154 // Current federated forms.
155 const std::vector<const autofill::PasswordForm*>& GetFederatedForms() const { 155 const std::vector<const autofill::PasswordForm*>& GetFederatedForms() const {
156 return passwords_data_.federated_credentials_forms(); 156 return passwords_data_.federated_credentials_forms();
157 } 157 }
158 158
159 // True if the password for previously stored account was overridden, i.e. in
160 // newly submitted form the password is different from stored one.
161 bool PasswordOverridden() const;
162
159 protected: 163 protected:
160 explicit ManagePasswordsUIController( 164 explicit ManagePasswordsUIController(
161 content::WebContents* web_contents); 165 content::WebContents* web_contents);
162 166
163 // The pieces of saving and blacklisting passwords that interact with 167 // The pieces of saving and blacklisting passwords that interact with
164 // FormManager, split off into internal functions for testing/mocking. 168 // FormManager, split off into internal functions for testing/mocking.
165 virtual void SavePasswordInternal(); 169 virtual void SavePasswordInternal();
166 virtual void UpdatePasswordInternal( 170 virtual void UpdatePasswordInternal(
167 const autofill::PasswordForm& password_form); 171 const autofill::PasswordForm& password_form);
168 virtual void NeverSavePasswordInternal(); 172 virtual void NeverSavePasswordInternal();
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 scoped_ptr<base::ElapsedTimer> timer_; 213 scoped_ptr<base::ElapsedTimer> timer_;
210 214
211 // Contains true if the bubble is to be popped up in the next call to 215 // Contains true if the bubble is to be popped up in the next call to
212 // UpdateBubbleAndIconVisibility(). 216 // UpdateBubbleAndIconVisibility().
213 bool should_pop_up_bubble_; 217 bool should_pop_up_bubble_;
214 218
215 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController); 219 DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
216 }; 220 };
217 221
218 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_ 222 #endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698