Implemented showing update bubble pop-up on password overriding

chrome/browser/ui/passwords/manage_passwords_ui_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_
 
 #include "base/memory/scoped_vector.h"
 #include "base/timer/elapsed_timer.h"
 #include "chrome/browser/ui/passwords/manage_passwords_state.h"
@@ skipping 138 matching lines @@
   // Current local forms.
   const std::vector<const autofill::PasswordForm*>& GetCurrentForms() const {
     return passwords_data_.GetCurrentForms();
   }
 
   // Current federated forms.
   const std::vector<const autofill::PasswordForm*>& GetFederatedForms() const {
     return passwords_data_.federated_credentials_forms();
   }
 
+  bool PasswordOverriden() const;

[vabr (Chromium), 2015/08/17 13:21:46]

nit: Please add a comment explaining who overrides the password. This might get
confused with the user overriding the generated passwords, so we need to mention
that this means that updating the password will override the old password of
this credential.

[dvadym, 2015/08/17 14:25:34]

I've added comment // True if the password for previously stored account was
overridden, i.e. on newly submitted form it's different from stored one.

+
  protected:
   explicit ManagePasswordsUIController(
       content::WebContents* web_contents);
 
   // The pieces of saving and blacklisting passwords that interact with
   // FormManager, split off into internal functions for testing/mocking.
   virtual void SavePasswordInternal();
   virtual void UpdatePasswordInternal(
       const autofill::PasswordForm& password_form);
   virtual void NeverSavePasswordInternal();
@@ skipping 40 matching lines @@
   scoped_ptr<base::ElapsedTimer> timer_;
 
   // Contains true if the bubble is to be popped up in the next call to
   // UpdateBubbleAndIconVisibility().
   bool should_pop_up_bubble_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsUIController);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_UI_CONTROLLER_H_