Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 129793012: Implement hook to change audio output device for PulseAudio. (Closed)

Created:
6 years, 10 months ago by Henrik Grunell
Modified:
6 years, 10 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Implement hook to change audio output device for PulseAudio. BUG=331305 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251165

Patch Set 1 #

Patch Set 2 : Clean up + rebase. #

Patch Set 3 : Rebase #

Patch Set 4 : Fix build error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M media/audio/pulse/audio_manager_pulse.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M media/audio/pulse/pulse_output.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M media/audio/pulse/pulse_output.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/pulse/pulse_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/pulse/pulse_util.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Henrik Grunell
Work so far (patch 1). Can change device, but not back to default.
6 years, 10 months ago (2014-02-12 13:34:55 UTC) #1
Henrik Grunell
On 2014/02/12 13:34:55, Henrik Grunell wrote: > Work so far (patch 1). Can change device, ...
6 years, 10 months ago (2014-02-12 13:41:23 UTC) #2
Henrik Grunell
Please review.
6 years, 10 months ago (2014-02-13 15:06:01 UTC) #3
tommi (sloooow) - chröme
lgtm
6 years, 10 months ago (2014-02-13 15:14:22 UTC) #4
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 10 months ago (2014-02-13 15:15:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/129793012/50001
6 years, 10 months ago (2014-02-13 15:16:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 15:37:51 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_rel_device_ninja for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device_ninja&number=1898
6 years, 10 months ago (2014-02-13 15:37:52 UTC) #8
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 10 months ago (2014-02-13 15:54:56 UTC) #9
no longer working on chromium
lgtm
6 years, 10 months ago (2014-02-13 15:55:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/129793012/260001
6 years, 10 months ago (2014-02-13 15:55:38 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 16:14:30 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=229256
6 years, 10 months ago (2014-02-13 16:14:31 UTC) #13
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 10 months ago (2014-02-13 16:32:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/129793012/70002
6 years, 10 months ago (2014-02-13 16:33:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/129793012/70002
6 years, 10 months ago (2014-02-13 19:48:31 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 20:09:17 UTC) #17
commit-bot: I haz the power
Commit queue patch verification failed without an error message. Something went wrong, probably a crash, ...
6 years, 10 months ago (2014-02-13 20:09:18 UTC) #18
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 10 months ago (2014-02-13 20:12:39 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/129793012/70002
6 years, 10 months ago (2014-02-13 20:17:27 UTC) #20
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 22:46:53 UTC) #21
Message was sent while issue was closed. 
Change committed as 251165

Powered by Google App Engine
This is Rietveld 408576698