Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 129793007: Remove dead code path (typed array interfaces) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index a70533e74130d63c9880750b1137d55cbcdf6400..45b99e4e034ed90fc3afcf467a3f76a61b1e3ba3 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -490,8 +490,6 @@ sub HeaderFilesForInterface
my @includes = ();
if (IsPrimitiveType($interfaceName) or IsEnumType($interfaceName) or IsCallbackFunctionType($interfaceName)) {
# Not interface type, no header files
- } elsif (IsTypedArrayType($interfaceName)) {
- push(@includes, "wtf/${interfaceName}.h");
} else {
my $idlFilename = Cwd::abs_path(IDLFileForInterface($interfaceName)) or die("Could NOT find IDL file for interface \"$interfaceName\" $!\n");
my $idlRelPath = File::Spec->abs2rel($idlFilename, $sourceRoot);
@@ -5144,13 +5142,6 @@ END
return wrapper;
END
- if (IsTypedArrayType($interface->name)) {
- AddToImplIncludes("bindings/v8/custom/V8ArrayBufferCustom.h");
- $code .= <<END;
- impl->buffer()->setDeallocationObserver(V8ArrayBufferDeallocationObserver::instanceTemplate());
-END
- }
-
if (InheritsInterface($interface, "AudioBuffer")) {
AddToImplIncludes("modules/webaudio/AudioBuffer.h");
$code .= <<END;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698