Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1297903005: DevTools: improve the color picker palette sorting algorithm. (Closed)

Created:
5 years, 4 months ago by pfeldman
Modified:
5 years, 4 months ago
Reviewers:
dgozman, samli
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: improve the color picker palette sorting algorithm. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200863

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -31 lines) Patch
M Source/devtools/front_end/elements/Spectrum.js View 1 5 chunks +19 lines, -30 lines 1 comment Download
M Source/devtools/front_end/elements/spectrum.css View 3 chunks +2 lines, -1 line 2 comments Download

Messages

Total messages: 9 (2 generated)
pfeldman
5 years, 4 months ago (2015-08-19 19:05:21 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1297903005/diff/20001/Source/devtools/front_end/elements/Spectrum.js File Source/devtools/front_end/elements/Spectrum.js (right): https://codereview.chromium.org/1297903005/diff/20001/Source/devtools/front_end/elements/Spectrum.js#newcode750 Source/devtools/front_end/elements/Spectrum.js:750: return hsvb[1]*hsvb[3] - hsva[1]*hsva[3]; nit: spaces around * ...
5 years, 4 months ago (2015-08-19 20:27:45 UTC) #3
pfeldman
https://codereview.chromium.org/1297903005/diff/20001/Source/devtools/front_end/elements/spectrum.css File Source/devtools/front_end/elements/spectrum.css (right): https://codereview.chromium.org/1297903005/diff/20001/Source/devtools/front_end/elements/spectrum.css#newcode205 Source/devtools/front_end/elements/spectrum.css:205: cursor: pointer; On 2015/08/19 20:27:45, dgozman wrote: > Please ...
5 years, 4 months ago (2015-08-19 20:29:03 UTC) #4
dgozman
On 2015/08/19 20:29:03, pfeldman wrote: > https://codereview.chromium.org/1297903005/diff/20001/Source/devtools/front_end/elements/spectrum.css > File Source/devtools/front_end/elements/spectrum.css (right): > > https://codereview.chromium.org/1297903005/diff/20001/Source/devtools/front_end/elements/spectrum.css#newcode205 > ...
5 years, 4 months ago (2015-08-19 20:35:10 UTC) #5
pfeldman
We'll have to remove that palette - it does not work so far.
5 years, 4 months ago (2015-08-19 21:31:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297903005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297903005/20001
5 years, 4 months ago (2015-08-19 21:31:57 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 00:11:37 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200863

Powered by Google App Engine
This is Rietveld 408576698