Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 12979004: More SkDrawCommand cleanup (Closed)

Created:
7 years, 9 months ago by robertphillips
Modified:
7 years, 9 months ago
Reviewers:
djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This is further bullet proofing of the SkDebugCanvas for when its supporting SkPicture is deleted (as is done in the debugger's SaveAs feature).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -70 lines) Patch
M debugger/SkDebugCanvas.cpp View 1 chunk +1 line, -1 line 0 comments Download
M debugger/SkDrawCommand.h View 7 chunks +33 lines, -19 lines 0 comments Download
M debugger/SkDrawCommand.cpp View 3 chunks +63 lines, -50 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
7 years, 9 months ago (2013-03-21 18:49:11 UTC) #1
djsollen
lgtm
7 years, 9 months ago (2013-03-21 18:50:32 UTC) #2
robertphillips
7 years, 9 months ago (2013-03-22 12:25:45 UTC) #3
Message was sent while issue was closed.
committed as r8328

Powered by Google App Engine
This is Rietveld 408576698