Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1297883002: Revert of Fix flaky crash in WebPagePopupImpl::closePopup. (Closed)

Created:
5 years, 4 months ago by tkent
Modified:
5 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Fix flaky crash in WebPagePopupImpl::closePopup. (patchset #1 id:1 of https://codereview.chromium.org/1291303002/ ) Reason for revert: Caused another issue. Original issue's description: > Fix flaky crash in WebPagePopupImpl::closePopup. > > Reentrance to WebViewImpl::closePagePopup is possible. closePopup crashed in > that case because m_page was valid and m_page->mainFrame() was nullptr. > > The details: > If WebViewImpl::closePagePopup is called, and the LocalFrame in the page popup > has the last references to the page popup owner Element, > 1. WebPagePopupImpl::closePopup() calls destroyPage(). > 2. destroyPage() calls Page::willBeDestroyed(). > 3. willBeDestroyed() destructs the LocalFrame. > 4. The LocalFrame destructor destructs the owner Element. > 5. The owner Element destructor destructs PickerIndicatorElement. > 6. PickerIndicatorElement destructor calls WebViewImpl::closePagePopup(). > > This CL changes WebViewImpl::closePagePopup() so that m_pagePopup is cleared > before calling WebPagePopupImpl::closePopup() to avoid reentrancy to it. > > BUG=454043 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200528 TBR=keishi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454043 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of Fix flaky crash in WebPagePopupImpl::closePopup.
5 years, 4 months ago (2015-08-17 02:21:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297883002/1
5 years, 4 months ago (2015-08-17 02:21:45 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 02:22:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200621

Powered by Google App Engine
This is Rietveld 408576698