Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1297803003: Revert of Remove property loads from js builtins objects from runtime. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove property loads from js builtins objects from runtime. (patchset #2 id:20001 of https://codereview.chromium.org/1293113002/ ) Reason for revert: Still failures in debug-isolates tests Original issue's description: > Remove property loads from js builtins objects from runtime. > > R=cbruni@chromium.org > > Committed: https://crrev.com/40f6e80d22d2e146b781aa661b76087ab9a492c4 > Cr-Commit-Position: refs/heads/master@{#30199} > > Committed: https://crrev.com/f22d0f205031054a5f3116e052c81ae85741e8e0 > Cr-Commit-Position: refs/heads/master@{#30209} TBR=cbruni@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/4106a4cbb701b5fe7d0b639e28a4ebfca5c05630 Cr-Commit-Position: refs/heads/master@{#30213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -83 lines) Patch
M src/api.cc View 7 chunks +40 lines, -36 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/contexts.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M src/messages.js View 7 chunks +21 lines, -17 lines 0 comments Download
M src/v8natives.js View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Created Revert of Remove property loads from js builtins objects from runtime.
5 years, 4 months ago (2015-08-18 09:37:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297803003/1
5 years, 4 months ago (2015-08-18 09:37:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 09:37:32 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4106a4cbb701b5fe7d0b639e28a4ebfca5c05630 Cr-Commit-Position: refs/heads/master@{#30213}
5 years, 4 months ago (2015-08-18 09:37:50 UTC) #4
Yang
5 years, 4 months ago (2015-08-18 09:55:24 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1298733003/ by yangguo@chromium.org.

The reason for reverting is: Debug isolate failure has nothing to do with this
CL..

Powered by Google App Engine
This is Rietveld 408576698