Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1297803002: Remove FOUC avoidance from BlockPainter and DeprecatedPaintLayerPainter. (Closed)

Created:
5 years, 4 months ago by esprehn
Modified:
5 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-paint_chromium.org, Inactive, dglazkov+blink, dshwang, eae+blinkwatch, rwlbuis, sof, slimming-paint-reviews_chromium.org, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove FOUC avoidance from BlockPainter and DeprecatedPaintLayerPainter. After r200515 we no longer start producing frames until the stylesheets have loaded which means we will never attempt to paint with pending sheets so we don't need the FOUC avoidance code that paints white. Lets remove it. See: https://src.chromium.org/viewvc/blink?revision=200515&view=revision Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200587

Patch Set 1 #

Patch Set 2 : Remove extra assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -62 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/fouc/scroll-left-while-loading.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/http/tests/fouc/scroll-left-while-loading-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/paint/BlockPainter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerPainter.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297803002/1
5 years, 4 months ago (2015-08-14 21:49:52 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/28478)
5 years, 4 months ago (2015-08-14 22:35:26 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297803002/20001
5 years, 4 months ago (2015-08-14 22:39:00 UTC) #6
esprehn
5 years, 4 months ago (2015-08-14 23:45:20 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-14 23:45:47 UTC) #10
esprehn
5 years, 4 months ago (2015-08-15 01:01:21 UTC) #12
pdr.
On 2015/08/15 at 01:01:21, esprehn wrote: > LGTM Can we test this (or https://codereview.chromium.org/1292143003) to ...
5 years, 4 months ago (2015-08-15 01:07:52 UTC) #13
esprehn
On 2015/08/15 at 01:07:52, pdr wrote: > On 2015/08/15 at 01:01:21, esprehn wrote: > > ...
5 years, 4 months ago (2015-08-15 01:16:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1297803002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1297803002/20001
5 years, 4 months ago (2015-08-15 01:18:13 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=200587
5 years, 4 months ago (2015-08-15 01:22:51 UTC) #17
esprehn
5 years, 4 months ago (2015-08-18 17:10:23 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1287113006/ by esprehn@chromium.org.

The reason for reverting is: Causes FOUC in iframes after the main frame has
finished loading..

Powered by Google App Engine
This is Rietveld 408576698