chrome/test/chromedriver/chrome/stub_chrome.h - Issue 12978003: [chromedriver] Fix 3 bugs about web view, window handle and target window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/stub_chrome.h

Issue 12978003: [chromedriver] Fix 3 bugs about web view, window handle and target window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/chrome/stub_chrome.h

diff --git a/chrome/test/chromedriver/chrome/stub_chrome.h b/chrome/test/chromedriver/chrome/stub_chrome.h

index 3f9475ad61fa7838a1ddc767011be3106150006e..a919be6ecdcbc1c9e4dee8e5fc07718546347606 100644

--- a/chrome/test/chromedriver/chrome/stub_chrome.h

+++ b/chrome/test/chromedriver/chrome/stub_chrome.h

@@ -20,7 +20,9 @@ class StubChrome : public Chrome {

// Overridden from Chrome:

virtual std::string GetVersion() OVERRIDE;

- virtual Status GetWebViews(std::list<WebView*>* web_views) OVERRIDE;

+ virtual Status GetWebViewIds(std::list<std::string>* web_view_ids) OVERRIDE;

+ virtual Status GetWebViewById(const std::string& id,

+ WebView** web_view) OVERRIDE;

virtual Status IsJavaScriptDialogOpen(bool* is_open) OVERRIDE;

virtual Status GetJavaScriptDialogMessage(std::string* message) OVERRIDE;

virtual Status HandleJavaScriptDialog(

« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/stub_chrome.cc » ('j') | no next file with comments »