Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/chrome/stub_chrome.h

Issue 12978003: [chromedriver] Fix 3 bugs about web view, window handle and target window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/chromedriver/chrome/chrome_impl.h ('K') | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/stub_chrome.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/stub_chrome.h
diff --git a/chrome/test/chromedriver/chrome/stub_chrome.h b/chrome/test/chromedriver/chrome/stub_chrome.h
index 3f9475ad61fa7838a1ddc767011be3106150006e..a919be6ecdcbc1c9e4dee8e5fc07718546347606 100644
--- a/chrome/test/chromedriver/chrome/stub_chrome.h
+++ b/chrome/test/chromedriver/chrome/stub_chrome.h
@@ -20,7 +20,9 @@ class StubChrome : public Chrome {
// Overridden from Chrome:
virtual std::string GetVersion() OVERRIDE;
- virtual Status GetWebViews(std::list<WebView*>* web_views) OVERRIDE;
+ virtual Status GetWebViewIds(std::list<std::string>* web_view_ids) OVERRIDE;
+ virtual Status GetWebViewById(const std::string& id,
+ WebView** web_view) OVERRIDE;
virtual Status IsJavaScriptDialogOpen(bool* is_open) OVERRIDE;
virtual Status GetJavaScriptDialogMessage(std::string* message) OVERRIDE;
virtual Status HandleJavaScriptDialog(
« chrome/test/chromedriver/chrome/chrome_impl.h ('K') | « chrome/test/chromedriver/chrome/chrome_impl.cc ('k') | chrome/test/chromedriver/chrome/stub_chrome.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698