Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6967)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.h

Issue 12978003: [chromedriver] Fix 3 bugs about web view, window handle and target window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_impl.h
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.h b/chrome/test/chromedriver/chrome/chrome_impl.h
index eb4bcdfbe07a77a228c8e7d0b2486161bb535518..0e4ba29bdbfc1c7f22b64550a70108c029e92e60 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.h
+++ b/chrome/test/chromedriver/chrome/chrome_impl.h
@@ -31,7 +31,9 @@ class ChromeImpl : public Chrome, public WebViewDelegate {
// Overridden from Chrome:
virtual std::string GetVersion() OVERRIDE;
- virtual Status GetWebViews(std::list<WebView*>* web_views) OVERRIDE;
+ virtual Status GetWebViewIds(std::list<std::string>* web_view_ids) OVERRIDE;
+ virtual Status GetWebViewById(const std::string& id,
+ WebView** web_view) OVERRIDE;
virtual Status IsJavaScriptDialogOpen(bool* is_open) OVERRIDE;
virtual Status GetJavaScriptDialogMessage(std::string* message) OVERRIDE;
virtual Status HandleJavaScriptDialog(
@@ -57,6 +59,8 @@ class ChromeImpl : public Chrome, public WebViewDelegate {
std::string version_;
int build_no_;
WebViewMap web_view_map_;
+ // Ids in this list are in the same order as the window opened.
chrisgao (Use stgao instead) 2013/03/22 23:29:46 window->web view
+ std::list<std::string> web_view_ids_;
};
namespace internal {
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_android_impl.cc ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698