Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: chrome/test/chromedriver/chrome/chrome.h

Issue 12978003: [chromedriver] Fix 3 bugs about web view, window handle and target window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome.h
diff --git a/chrome/test/chromedriver/chrome/chrome.h b/chrome/test/chromedriver/chrome/chrome.h
index 85ac7fa0c6d8d8029ede9e1490afb10e9fb35fb7..1e64cdf29dd932ff58b9e4cfd46770625f8d4c24 100644
--- a/chrome/test/chromedriver/chrome/chrome.h
+++ b/chrome/test/chromedriver/chrome/chrome.h
@@ -17,8 +17,11 @@ class Chrome {
virtual std::string GetVersion() = 0;
- // Return a list of opened WebViews.
- virtual Status GetWebViews(std::list<WebView*>* web_views) = 0;
+ // Return ids of opened WebViews in the same order as they are opened.
+ virtual Status GetWebViewIds(std::list<std::string>* web_view_ids) = 0;
+
+ // Return the WebView for the given id.
+ virtual Status GetWebViewById(const std::string& id, WebView** web_view) = 0;
// Returns whether a JavaScript dialog is open.
virtual Status IsJavaScriptDialogOpen(bool* is_open) = 0;
« no previous file with comments | « no previous file | chrome/test/chromedriver/chrome/chrome_android_impl.cc » ('j') | chrome/test/chromedriver/chrome/chrome_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698