Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/test/chromedriver/session_unittest.cc

Issue 12978003: [chromedriver] Fix 3 bugs about web view, window handle and target window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/session_unittest.cc
diff --git a/chrome/test/chromedriver/session_unittest.cc b/chrome/test/chromedriver/session_unittest.cc
index 22557e3cddd054e29f6d60bc1fce1e7d1652ed99..5f6d0d02fcd0d070f6eb3915c6539c29b9d1764a 100644
--- a/chrome/test/chromedriver/session_unittest.cc
+++ b/chrome/test/chromedriver/session_unittest.cc
@@ -31,10 +31,13 @@ class MockChrome : public StubChrome {
MockChrome() : web_view_("1") {}
virtual ~MockChrome() {}
- virtual Status GetWebViews(std::list<WebView*>* web_views) OVERRIDE {
- web_views->clear();
- web_views->push_back(&web_view_);
- return Status(kOk);
+ virtual Status GetWebViewById(const std::string& id,
+ WebView** web_view) OVERRIDE {
+ if (id == web_view_.GetId()) {
+ *web_view = &web_view_;
+ return Status(kOk);
+ }
+ return Status(kUnknownError);
}
private:
« chrome/test/chromedriver/chrome/chrome_impl.h ('K') | « chrome/test/chromedriver/session_commands.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698