Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 12978002: Keep the 'fetching files' message until the Drive root is ready to be read. (Closed)

Created:
7 years, 9 months ago by kinaba
Modified:
7 years, 9 months ago
Reviewers:
mtomasz, satorux1
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Keep the 'fetching files' message until the Drive root is ready to be read. For introducing the 'fast-fetch' feature, getDirectory(root) is changed not to trigger feed loading anymore. To wait for Drive really ready for operations, we need to wait for directoryReader.readEntries() to finish. BUG=197246 TEST=Open Files.app > "Google Drive", ctrl-click gear menu and clean local cache. Verify spinner with some text "fetching files" is shown, not just a spinner animation. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M chrome/browser/resources/file_manager/js/volume_manager.js View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
kinaba
ptal. +mtomasz: as a file-manager OWNER. +satorux: as a fast-fetch guy. Note: if fast-fetch ideally ...
7 years, 9 months ago (2013-03-21 04:57:42 UTC) #1
satorux1
LGTM. Interesting. I wasn't hit by this issue while I was working on fast-fetch. Why ...
7 years, 9 months ago (2013-03-21 05:00:53 UTC) #2
kinaba
On 2013/03/21 05:00:53, satorux1 wrote: > LGTM. Interesting. I wasn't hit by this issue while ...
7 years, 9 months ago (2013-03-21 05:10:38 UTC) #3
mtomasz
On 2013/03/21 05:10:38, kinaba wrote: > On 2013/03/21 05:00:53, satorux1 wrote: > > LGTM. Interesting. ...
7 years, 9 months ago (2013-03-21 05:18:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/12978002/1
7 years, 9 months ago (2013-03-21 05:24:05 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=22031
7 years, 9 months ago (2013-03-21 09:55:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/12978002/1
7 years, 9 months ago (2013-03-21 10:46:40 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=22182
7 years, 9 months ago (2013-03-21 14:00:57 UTC) #8
kinaba
7 years, 9 months ago (2013-03-21 14:52:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r189599 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698