core/src/fpdfapi/fpdf_page/pageint.h - Issue 1297723002: CFX_MapByteStringToPtr considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/pageint.h

Issue 1297723002: CFX_MapByteStringToPtr considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Const auto& Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/pageint.h

diff --git a/core/src/fpdfapi/fpdf_page/pageint.h b/core/src/fpdfapi/fpdf_page/pageint.h

index bc03c3b5e6a0bcfcba837673818f854fbca3b45c..6bec07268ce2bcaa792f12617f47902dae8564e4 100644

--- a/core/src/fpdfapi/fpdf_page/pageint.h

+++ b/core/src/fpdfapi/fpdf_page/pageint.h

@@ -422,9 +422,8 @@ class CPDF_DocPageData {

using CPDF_PatternMap = std::map<CPDF_Object*, CPDF_CountedPattern*>;

CPDF_Document* const m_pPDFDoc;

- CFX_MapByteStringToPtr m_HashProfileMap;

FX_BOOL m_bForceClear;

+ std::map<CFX_ByteString, CPDF_Stream*> m_HashProfileMap;

CPDF_ColorSpaceMap m_ColorSpaceMap;

CPDF_FontFileMap m_FontFileMap;

CPDF_FontMap m_FontMap;