Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/include/javascript/global.h

Issue 1297723002: CFX_MapByteStringToPtr considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Separate reload & delete. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« fpdfsdk/include/fsdk_annothandler.h ('K') | « fpdfsdk/include/fsdk_annothandler.h ('k') | fpdfsdk/src/fsdk_annothandler.cpp » ('j') | fpdfsdk/src/javascript/global.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/include/javascript/global.h
diff --git a/fpdfsdk/include/javascript/global.h b/fpdfsdk/include/javascript/global.h
index 303ac76a3e01b6072139b605715dbca10e418f83..ae3882fe7008150551d8956a13e9521ee0a8e2a4 100644
--- a/fpdfsdk/include/javascript/global.h
+++ b/fpdfsdk/include/javascript/global.h
@@ -7,6 +7,8 @@
#ifndef FPDFSDK_INCLUDE_JAVASCRIPT_GLOBAL_H_
#define FPDFSDK_INCLUDE_JAVASCRIPT_GLOBAL_H_
+#include <map>
+
#include "JS_Define.h"
class CJS_GlobalData;
@@ -73,7 +75,7 @@ class global_alternate : public CJS_EmbedObj {
void PutObjectProperty(v8::Local<v8::Object> obj, CJS_KeyValue* pData);
private:
- CFX_MapByteStringToPtr m_mapGlobal;
+ std::map<CFX_ByteString, js_global_data*> m_mapGlobal;
CFX_WideString m_sFilePath;
CJS_GlobalData* m_pGlobalData;
CPDFDoc_Environment* m_pApp;
« fpdfsdk/include/fsdk_annothandler.h ('K') | « fpdfsdk/include/fsdk_annothandler.h ('k') | fpdfsdk/src/fsdk_annothandler.cpp » ('j') | fpdfsdk/src/javascript/global.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698