core/src/fxcodec/codec/codec_int.h - Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/codec/codec_int.h

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcodec/codec/codec_int.h

diff --git a/core/src/fxcodec/codec/codec_int.h b/core/src/fxcodec/codec/codec_int.h

index 9fe77a44f718e1201370ffe831047999be5b0f96..e7baa585f92fb6c1f1e1e5b14e421dd43ba6a37c 100644

--- a/core/src/fxcodec/codec/codec_int.h

+++ b/core/src/fxcodec/codec/codec_int.h

@@ -54,9 +54,7 @@ class CCodec_ScanlineDecoder : public ICodec_ScanlineDecoder {

int GetBPC() override { return m_bpc; }

FX_BOOL IsColorTransformed() override { return m_bColorTransformed; }

void ClearImageData() override {

- if (m_pDataCache) {

- FX_Free(m_pDataCache);

- }

+ FX_Free(m_pDataCache);

m_pDataCache = NULL;

}

« no previous file with comments | « core/src/fpdftext/fpdf_text.cpp ('k') | core/src/fxcodec/codec/fx_codec.cpp » ('j') | no next file with comments »