core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp - Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

diff --git a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

index 3c8b2567fe8490005271a4154acd07fd690b7e8f..6c728242e6d1a39e5430eaf44a3d87930219fa95 100644

--- a/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

+++ b/core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp

@@ -301,15 +301,9 @@ CPDF_CMap::CPDF_CMap() {

m_nCodeRanges = 0;

}

CPDF_CMap::~CPDF_CMap() {

- if (m_pMapping) {

- FX_Free(m_pMapping);

- }

- if (m_pAddMapping) {

- FX_Free(m_pAddMapping);

- }

- if (m_pLeadingBytes) {

- FX_Free(m_pLeadingBytes);

- }

+ FX_Free(m_pMapping);

+ FX_Free(m_pAddMapping);

+ FX_Free(m_pLeadingBytes);

delete m_pUseMap;

}

void CPDF_CMap::Release() {

« no previous file with comments | « core/src/fpdfapi/fpdf_font/fpdf_font.cpp ('k') | core/src/fpdfapi/fpdf_font/ttgsubtable.h » ('j') | no next file with comments »