core/src/fxge/win32/fx_win32_device.cpp - Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/win32/fx_win32_device.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/win32/fx_win32_device.cpp

diff --git a/core/src/fxge/win32/fx_win32_device.cpp b/core/src/fxge/win32/fx_win32_device.cpp

index c3325ba7388ec20df35c63ebb2471ae7d8a98bdb..98c2a3900769043e99ec21b01e8fab68fddfd8dc 100644

--- a/core/src/fxge/win32/fx_win32_device.cpp

+++ b/core/src/fxge/win32/fx_win32_device.cpp

@@ -695,9 +695,7 @@ static HPEN _CreatePen(const CFX_GraphStateData* pGraphState,

}

HPEN hPen = ExtCreatePen(PenStyle, (DWORD)FXSYS_ceil(width), &lb,

pGraphState->m_DashCount, (const DWORD*)pDash);

- if (pDash) {

FX_Free(pDash);

- }

return hPen;

}

static HBRUSH _CreateBrush(FX_DWORD argb) {