core/src/fxge/ge/fx_ge_fontmap.cpp - Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/ge/fx_ge_fontmap.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/ge/fx_ge_fontmap.cpp

diff --git a/core/src/fxge/ge/fx_ge_fontmap.cpp b/core/src/fxge/ge/fx_ge_fontmap.cpp

index d4416d9487944bb28ffe6a33a011cc068d285b20..0e508ea96ed22f59c2d7ab6bf067bea1694f886a 100644

--- a/core/src/fxge/ge/fx_ge_fontmap.cpp

+++ b/core/src/fxge/ge/fx_ge_fontmap.cpp

@@ -33,9 +33,7 @@ CTTFontDesc::~CTTFontDesc() {

FXFT_Done_Face(m_TTCFace.m_pFaces[i]);

}

- if (m_pFontData) {

FX_Free(m_pFontData);

- }

}

FX_BOOL CTTFontDesc::ReleaseFace(FXFT_Face face) {

if (m_Type == 1) {