Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: core/src/fxcrt/xml_int.h

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp ('K') | « core/src/fxcrt/fx_basic_maps.cpp ('k') | core/src/fxge/android/fpf_skiafontmgr.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/src/fxcrt/xml_int.h
diff --git a/core/src/fxcrt/xml_int.h b/core/src/fxcrt/xml_int.h
index 1008436c8452542fa34a13782f8d79fff75fb5b8..ee2cbef7a621114527c4bea0c954a1add984863a 100644
--- a/core/src/fxcrt/xml_int.h
+++ b/core/src/fxcrt/xml_int.h
@@ -45,9 +45,7 @@ class CXML_DataStmAcc : public IFX_BufferRead {
FXSYS_assert(m_pFileRead != NULL);
}
virtual ~CXML_DataStmAcc() {
- if (m_pBuffer) {
FX_Free(m_pBuffer);
- }
}
virtual void Release() { delete this; }
virtual FX_BOOL IsEOF() {
« core/src/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp ('K') | « core/src/fxcrt/fx_basic_maps.cpp ('k') | core/src/fxge/android/fpf_skiafontmgr.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698