Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3001)

Unified Diff: core/src/fxcodec/codec/fx_codec_fax.cpp

Issue 1297713003: Don't bother checking pointers before delete[] and FX_Free(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/src/fxcodec/codec/fx_codec_fax.cpp
diff --git a/core/src/fxcodec/codec/fx_codec_fax.cpp b/core/src/fxcodec/codec/fx_codec_fax.cpp
index 4260309380010e955c424bff7fba9b9302098e10..ec40b6cb95860ceba328a03ffe89babf027813f6 100644
--- a/core/src/fxcodec/codec/fx_codec_fax.cpp
+++ b/core/src/fxcodec/codec/fx_codec_fax.cpp
@@ -485,12 +485,8 @@ CCodec_FaxDecoder::CCodec_FaxDecoder() {
m_pRefBuf = NULL;
}
CCodec_FaxDecoder::~CCodec_FaxDecoder() {
- if (m_pScanlineBuf) {
FX_Free(m_pScanlineBuf);
- }
- if (m_pRefBuf) {
FX_Free(m_pRefBuf);
- }
}
FX_BOOL CCodec_FaxDecoder::Create(const uint8_t* src_buf,
FX_DWORD src_size,
@@ -764,12 +760,8 @@ CCodec_FaxEncoder::CCodec_FaxEncoder(const uint8_t* src_buf,
m_DestBuf.EstimateSize(0, 10240);
}
CCodec_FaxEncoder::~CCodec_FaxEncoder() {
- if (m_pRefLine) {
FX_Free(m_pRefLine);
- }
- if (m_pLineBuf) {
FX_Free(m_pLineBuf);
- }
}
void CCodec_FaxEncoder::Encode(uint8_t*& dest_buf, FX_DWORD& dest_size) {
int dest_bitpos = 0;

Powered by Google App Engine
This is Rietveld 408576698